Closed
Conversation
Flowdalic
requested changes
Jul 13, 2021
Owner
Flowdalic
left a comment
Flowdalic
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I love the idea and script approach. I only have minor suggestions.
Owner
|
Lgtm. Please squash the commit. And in the future, you may want to use a different source branch name as the target branch. |
Author
|
uh the pr autoclosed, i gonna clean up my squashing mess and push again ^^ if it doesnt auto reopen i just gonna create a new pr |
nothub
added a commit
to nothub/java-pinning
that referenced
this pull request
Jul 13, 2021
see pr Flowdalic#13 on github
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a java version of coreequip's groovy script from #11
( can just have either a .java ending or the shebang, so it has the shebang )