6791 - Sentry: SecurityError — removeEventListener from cross-origin Window #6792
Open
6791 - Sentry: SecurityError — removeEventListener from cross-origin Window #6792
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6792 +/- ##
==========================================
- Coverage 76.65% 76.60% -0.06%
==========================================
Files 398 398
Lines 20108 20122 +14
Branches 4844 4844
==========================================
Hits 15414 15414
- Misses 4694 4708 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ank on beforeUnmount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a
SecurityError: Failed to read a named property 'removeEventListener' from 'Window'triggered when navigating away from the instance editor.The error was caused by PostHog's rrweb-based session recorder failing to detach from the cross-origin Node-RED iframe during route teardown. Fixed by clearing the iframe src to
about:blankinbeforeUnmounton bothHostedInstanceEditorWrapperandRemoteInstanceEditorWrapper— making the iframe same-origin at cleanup time so the browser permits the listener removal.Full details here.
Related Issue(s)
Resolves #6791
Checklist
This is a config change.
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel