Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6761 +/- ##
=======================================
Coverage 76.65% 76.65%
=======================================
Files 398 398
Lines 20108 20108
Branches 4844 4844
=======================================
Hits 15414 15414
Misses 4694 4694
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Odd test fail - wonder iff sass is throwing something off? I looked in pre-staging team |
Contributor
Author
@cstns do you know how to view cypress screenshots to see what it was seeing? |
Contributor
|
taking a look at the test artifacts |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
node-sasswithsasspackage.devModeflag derived from the standard webpack modeargv.modeis webpack's canonical flag and enables built-in optimizations (minify, tree-shaking, etc.).process.env.modeis nonstandard!Package Size Improvements = click to expand
node-sass 5.17MB
sass (without the sass compression) 5.21MB
sass (with sass compression) 4.58MB
Webpack environment handling and loader configuration:
config/webpack.config.jsto use adevModevariable for environment detection, ensuring consistent behavior throughout the config. This changes howdevtoolis set and how loaders are selected.style-loaderin development andMiniCssExtractPlugin.loaderin production, improving build performance and hot-reloading in development. [1] [2]__VUE_PROD_DEVTOOLS__definition to use the newdevModevariable for clarity and consistency.Sass configuration and dependency updates:
sassOptions.silenceDeprecationsto thesass-loaderconfig to silence warnings about the deprecated@importsyntax, reducing console noise during builds.node-sasspackage with the recommendedsasspackage inpackage.jsonfor better compatibility and future support.Related Issue(s)
closes #6730
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel