Improve bulk device group assignment #6379
Merged
+260
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, alerts, and related UI elements
… handle content overflow in Accordion and list selected devices
- Add "Remove" button for individual devices with disable condition - Emit `selection-removed` event when devices are removed - Improve DataTable row key handling and integrate dialog state
- Add ref to DataTable for programmatic row toggle - Watch and sync `checkedDevices` with dialog state - Add `removeFromSelection` method and bind it to `selection-removed` event
…oup" - Refactor computed properties for application ownership, single-device assignment, and disabling primary actions. - Simplify device group fetching logic with application parameter. - Remove redundant validation methods and integrate ownership checks directly into computed properties. - Enhance UI logic with conditional rendering and alignment tweaks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6379 +/- ##
=======================================
Coverage 76.22% 76.22%
=======================================
Files 393 393
Lines 19788 19789 +1
Branches 4743 4744 +1
=======================================
+ Hits 15084 15085 +1
Misses 4704 4704
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lection - Move "Add Device to Group" dialog to `device-group-management` folder. - Create new "Remove Device From Group" dialog. - Replace inline device selection UI with reusable `DeviceList` component. - Simplify UI and state handling for group management dialogs.
Contributor
|
Maybe pre-expand list if there are warnings/errors 
|
Contributor
Author
|
I created a follow up task: #6430 for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the bulk device group assignment user experience by extending the "Add to Group" and "Remove from Group" dialogs to include a collapsible list of selected devices, allowing users to review and modify their selection before confirming.
Key Changes:
DevicesBrowser.vuebulk-device-group-assignment.mp4
Related Issue(s)
closes #6164
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel