Skip to content

Conversation

@cstns
Copy link
Contributor

@cstns cstns commented Nov 18, 2025

Description

fixes SnapshotDetailsDrawer padding

Before:
image

After:
image

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Nov 18, 2025
Copy link
Contributor

@dimitrieh dimitrieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update this to a standard padding? Afaik we use tailwind spacing as much as possible, which are either multiples of 4px or 8px

See
CleanShot 2025-11-18 at 12 17 31@2x

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.61%. Comparing base (9e911c8) to head (3194ef4).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6305   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files         387      387           
  Lines       19582    19582           
  Branches     4707     4707           
=======================================
  Hits        15003    15003           
  Misses       4579     4579           
Flag Coverage Δ
backend 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dimitrieh dimitrieh self-requested a review November 18, 2025 12:40
Copy link
Contributor

@dimitrieh dimitrieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll 💪

@cstns cstns merged commit 68b3f49 into main Nov 19, 2025
45 of 53 checks passed
@cstns cstns deleted the fix/snapshot-drawer-padding branch November 19, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants