Skip to content

Conversation

@hardillb
Copy link
Contributor

fixes #6135

Description

Adds Expiry and Idle values in hours to SSO settings.

If not set default to platform wide settings

Related Issue(s)

#6135

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

fixes #6135

Adds Expiry and Idle values in hours to SSO settings.

If not set default to platform wide settings
@hardillb hardillb self-assigned this Oct 30, 2025
@hardillb
Copy link
Contributor Author

Needs tests and input validators

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.86%. Comparing base (d593989) to head (a7c70d5).
⚠️ Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/lib/sso/index.js 0.00% 2 Missing ⚠️
forge/ee/routes/sso/auth.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6215      +/-   ##
==========================================
+ Coverage   76.79%   76.86%   +0.06%     
==========================================
  Files         384      385       +1     
  Lines       19439    19452      +13     
  Branches     4671     4679       +8     
==========================================
+ Hits        14928    14951      +23     
+ Misses       4511     4501      -10     
Flag Coverage Δ
backend 76.86% <81.81%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hardillb hardillb marked this pull request as ready for review October 31, 2025 12:33
@hardillb hardillb moved this to Review in 🛠 Development Oct 31, 2025
@hardillb hardillb added this to the 2.24 milestone Oct 31, 2025
@knolleary knolleary merged commit c049bff into main Nov 5, 2025
25 checks passed
@knolleary knolleary deleted the sso-custom-session-timeout branch November 5, 2025 13:40
@knolleary knolleary removed this from the 2.24 milestone Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

Allow session expiry settings to be customised as part of SSO configuration

3 participants