Skip to content

Conversation

@cstns
Copy link
Contributor

@cstns cstns commented Oct 15, 2025

Description

BE:

  • added flows as an optional parameter on instance creation
  • added gate to prevent simultaneous blueprint/flow deployment
  • when flows are present on the request, a new StorageFlow will be created to deploy them to the newly created instance

UI:

  • renamed the multi-step-form blueprint step to flows to allow both blueprint and flows import
  • altered the multistep form styling for a better scrolling experience
  • force re-render the FlowViewer when flows change in order to support re-renderings on flows change
  • preserved the blueprint step name when deploying flows and disabled the section selector in that scenario
  • hides blueprint section and section selector when blueprints are not present
  • flows can be uploaded via a file or pasted in a textarea with immediate rendering
image

Related Issue(s)

closes #5751

Checklist

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns marked this pull request as draft October 15, 2025 12:58
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.82%. Comparing base (17ce7dd) to head (735f894).
⚠️ Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
forge/db/controllers/Project.js 50.00% 4 Missing ⚠️
forge/routes/api/project.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6137   +/-   ##
=======================================
  Coverage   76.82%   76.82%           
=======================================
  Files         381      381           
  Lines       19306    19330   +24     
  Branches     4647     4653    +6     
=======================================
+ Hits        14831    14850   +19     
- Misses       4475     4480    +5     
Flag Coverage Δ
backend 76.82% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cstns cstns self-assigned this Oct 16, 2025
@cstns cstns marked this pull request as ready for review October 16, 2025 15:23
@hardillb
Copy link
Contributor

Initial things:

  1. the warning is too big env on my 4k screen
image

The box to paste the flow into is hidden until I mouse over it.

@hardillb
Copy link
Contributor

Functionally works as expected

Not a fan of the clear button on the side at full hight like that

image

Having the "blue warnings" at the bottom is better, still takes up more space than I'd like at some screen sizes.

There is still some odd layout at some window sizes, but I can probably let that go

Screencast.From.2025-10-17.11-33-51.mp4

Will read the code to see if I spot anything else then will approve this PR to merge to the other one and we can decided if there are any other tweaks needed

@cstns
Copy link
Contributor Author

cstns commented Oct 17, 2025

The button is definitely not supposed to be displayed like that, taking a look

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty happy with this via testing

Just the note about the POST schema

@hardillb
Copy link
Contributor

@cstns is this "done"? I'll trigger re-run of the UI tests and have one last look

@cstns
Copy link
Contributor Author

cstns commented Oct 20, 2025

it's done, yes, but the e2e tests are only failing on GH actions and not locally. The artefacts are not conclusive and don't even know how to approach this. And there's also the docker/aws outage

Base automatically changed from fix-flow-viewer-resizing to main October 20, 2025 10:18
@hardillb
Copy link
Contributor

Approved, pending a clean UI test run

@cstns cstns mentioned this pull request Oct 20, 2025
11 tasks
@cstns cstns merged commit 889d875 into main Oct 21, 2025
23 checks passed
@cstns cstns deleted the multi-step-form-import-flows branch October 21, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create 'Import from JSON' step in Add Instance workflow

3 participants