Skip to content

Conversation

@cstns
Copy link
Contributor

@cstns cstns commented Sep 25, 2025

Description

Update the dashboard instances api endpoint to filter out instances based on rbac application context.

I also needed to define a new permission, team:projects:list-dashboards, to check against. This permission (dashboard role) should be lower than the existing team:projects:list (viewer role) to allow dashboard users to list available instances while blocking those where their team application role is None (0).

Related Issue(s)

N/a

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from knolleary September 25, 2025 14:24
@cstns cstns self-assigned this Sep 25, 2025
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.70%. Comparing base (b1bd883) to head (d6a8938).
⚠️ Report is 4 commits behind head on 5745-granular-rbac-backend.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           5745-granular-rbac-backend    #6061   +/-   ##
===========================================================
  Coverage                       76.69%   76.70%           
===========================================================
  Files                             380      380           
  Lines                           19119    19124    +5     
  Branches                         4565     4566    +1     
===========================================================
+ Hits                            14664    14669    +5     
  Misses                           4455     4455           
Flag Coverage Δ
backend 76.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knolleary knolleary merged commit 39d0a03 into 5745-granular-rbac-backend Sep 26, 2025
23 checks passed
@knolleary knolleary deleted the rbac-contextual-filtering-for-dashboard-instances branch September 26, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants