Technical Debt (dev-dependencies) #6457
Description
Description
TL;DR;
This top-level issue should be used to track these 2 tech dept items:
should(and potentially mocha/sinon)- eslint v8 → v9 (Default .eslintrc is out of date .github#9)
Details
When we moved from Fastify v4 to v5, it highlighted the fact we still use shouldjs for our tests because we had to update 40+ tests due to the removal of prototype in the request params (ref). While moving to chai may or may not have suffered the same fate, it is still a debt.
Upon discussion in Eng meeting, it was decided to lump this (shouldjs dependency) with the fact we also need to update eslint from v8 to v9 across several of our repos and in the absence of a better place to put this right now, we are to add it here in the FF repo.
ESLINT
For reference: nr-ai-nodes, nr-tables-nodes and nr-subflow-export are already rocking eslint v9 (so clues on how-to-move from eslint v8 to v9 can be extracted from those)
SHOULD
As of Node v20, the built in node native test runner (node:test) is marked stable. In theory, the built-in node:test module, combined with node:assert could replace the whole Mocha/Should.js/Sinon stack.
Sub-tasks will be added as required.
Which customers would this be available to
None