Skip to content

Conversation

@rrrooommmaaa
Copy link
Contributor

This PR fixes ContactStore.extractPubkeys()

close #3659


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for this particular PR, but it would be good to test this with UI tests (click the export all button, and expect pubkeys to come out).

@tomholub tomholub merged commit 40127cb into master May 22, 2021
@tomholub tomholub deleted the issue-3659-searchpubkeys-fix branch May 22, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export all contacts feature broken

2 participants