fix(ui): make tooltip labels readable - #99
Open
D-Lite wants to merge 1 commit into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sidebar (and every other) tooltip rendered as a near-black chip with unreadable text. Garden maps
--backgroundtotransparentso parchment shows through the page; the shadcn inverted pairbg-foreground text-backgroundtherefore painted ink fill with invisible (transparent) text.Tooltips now use the opaque popover surface (
bg-popover/text-popover-foreground) already used by HoverCard and Popover — ink on vellum, with the matching arrow. Keyboard hint styles that assumed an inverted tooltip were dropped so they don't go invisible on the light surface.Impact: rail labels, settings, issue actions, and any other
TooltipContentare readable. No product behavior change.Scope
packages/ui/components/ui/tooltip.tsxsurface + arrow tokenspackages/ui/components/ui/kbd.tsxtooltip-inverted kbd overrides--backgroundremaining transparent (intentional for page atmosphere)bg-foreground text-backgroundcall sites (onboarding CTAs, automation chips)Invariants
List the business and engineering rules that must remain true.
Design
Source of truth for floating chrome is
--popover/--popover-foreground(vellum-heavy+ink).--backgroundstays transparent by design; it is not a text color. Read path is CSS only. No error/retry surface. Simplest safe fix is reuse the existing opaque popover tokens instead of introducing new ones or making--backgroundopaque (which would flatten the parchment ground).Duplicate and idempotency review
Privacy and security review
Data, migration, and rollback
Verification
Commands and actual results:
Manual: hover a collapsed-rail icon (e.g. Connections) and confirm the label is ink on a light chip, not a black empty blob. Could not hover the authenticated sidebar from the agent browser (redirected to login); token measurement used the same live stylesheet.
Operations
Agent declaration
AGENTS.mdinstructions.Media