Skip to content

Fix: Ensure QueryTextBox receives focus after Win+R & new FocusQueryTextBox api function #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

onesounds
Copy link
Contributor

What's the PR

  • Fixes an issue where QueryTextBox did not receive focus when the launcher was shown via Win+R shortcut. (Shell Plugin)
  • This was due to OS-level focus interference. Resolved by introducing a short delay before applying focus.

Reproduce

  • In dev build, enable the Win+R setting in the Shell plugin and run the launcher
  • Verify that the input box does not receive focus.

Problem

When launching Flow Launcher via the Win+R shortcut (with the Shell plugin's setting enabled), the main window appears, but the input box (QueryTextBox) does not receive focus, preventing immediate typing.

Cause

This happens because Win+R is a system-reserved shortcut. Even though the plugin intercepts the keyboard event and shows the main window, Windows continues to process the Win key, and briefly reclaims focus, typically sending it to the Start menu or background. As a result, any Focus() call issued immediately after ShowMainWindow() is overridden.

Solution

To work around the OS-level focus interference:

  • We introduced a slight delay (Task.Delay) after showing the main window before explicitly calling FocusQueryTextBox().

  • This ensures that Windows has completed handling the Win key and the plugin regains control to correctly apply focus.

@prlabeler prlabeler bot added the bug Something isn't working label May 21, 2025

This comment has been minimized.

Copy link

gitstream-cm bot commented May 21, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Copy link
Contributor

coderabbitai bot commented May 21, 2025

📝 Walkthrough

Walkthrough

A new method, FocusQueryTextBox(), was introduced to the IPublicAPI interface and implemented in PublicAPIInstance. The method programmatically focuses the query text box in the main window. The OnWinRPressed method in the shell plugin was updated to show the main window synchronously, then asynchronously update the query and focus the query box after a short delay.

Changes

File(s) Change Summary
Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs Added FocusQueryTextBox() method to the IPublicAPI interface.
Flow.Launcher/PublicAPIInstance.cs Implemented FocusQueryTextBox() delegating focus call to main view model.
Flow.Launcher/ViewModel/MainViewModel.cs Added FocusQueryTextBox() method to set keyboard focus on the query text box safely on UI thread.
Plugins/Flow.Launcher.Plugin.Shell/Main.cs Modified OnWinRPressed to show main window synchronously, then asynchronously change query and focus the query box with a delay.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ShellPlugin
    participant PublicAPI
    participant MainViewModel
    participant MainWindow

    User->>ShellPlugin: Press Win+R
    ShellPlugin->>PublicAPI: ShowMainWindow()
    PublicAPI->>MainWindow: Show()
    Note right of ShellPlugin: Wait 50ms asynchronously
    ShellPlugin->>PublicAPI: ChangeQuery(newQuery)
    PublicAPI->>MainViewModel: ChangeQuery(newQuery)
    ShellPlugin->>PublicAPI: FocusQueryTextBox()
    PublicAPI->>MainViewModel: FocusQueryTextBox()
    MainViewModel->>MainWindow: Set keyboard focus on QueryTextBox
Loading

Suggested reviewers

  • taooceros
  • jjw24

Poem

In the warren of code where queries hop,
A new method helps the searching not stop.
With a twitch of the nose and a tap of the key,
The query box focuses—oh, so swiftly!
Now bunnies and users can search with delight,
For the textbox awaits, focused and bright. 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between edae432 and 3718ae5.

📒 Files selected for processing (3)
  • Flow.Launcher/PublicAPIInstance.cs (3 hunks)
  • Flow.Launcher/ViewModel/MainViewModel.cs (1 hunks)
  • Plugins/Flow.Launcher.Plugin.Shell/Main.cs (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • Flow.Launcher/ViewModel/MainViewModel.cs
🚧 Files skipped from review as they are similar to previous changes (2)
  • Flow.Launcher/PublicAPIInstance.cs
  • Plugins/Flow.Launcher.Plugin.Shell/Main.cs
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 23
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Jack251970 Jack251970 added this to the 1.20.0 milestone May 22, 2025
@Jack251970 Jack251970 merged commit 2beab53 into Flow-Launcher:dev May 22, 2025
8 checks passed
@jjw24 jjw24 changed the title Fix: Ensure QueryTextBox receives focus after Win+R Fix: Ensure QueryTextBox receives focus after Win+R & new FocusQueryTextBox api function Jun 3, 2025
@jjw24 jjw24 added enhancement New feature or request and removed bug Something isn't working labels Jun 3, 2025
Copy link

gitstream-cm bot commented Jun 3, 2025

🥷 Code experts: Jack251970

Jack251970, onesounds have most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs

Activity based on git-commit:

Jack251970 onesounds
JUN
MAY 4 additions & 1 deletions 5 additions & 0 deletions
APR 228 additions & 27 deletions
MAR
FEB 38 additions & 28 deletions
JAN 21 additions & 3 deletions

Knowledge based on git-blame:
Jack251970: 47%

Flow.Launcher/PublicAPIInstance.cs

Activity based on git-commit:

Jack251970 onesounds
JUN
MAY 124 additions & 131 deletions 190 additions & 74 deletions
APR 165 additions & 61 deletions
MAR 21 additions & 19 deletions
FEB 28 additions & 11 deletions
JAN 45 additions & 47 deletions

Knowledge based on git-blame:
Jack251970: 49%

Flow.Launcher/ViewModel/MainViewModel.cs

Activity based on git-commit:

Jack251970 onesounds
JUN 25 additions & 13 deletions
MAY 529 additions & 316 deletions 4 additions & 0 deletions
APR 35 additions & 28 deletions
MAR 695 additions & 628 deletions 293 additions & 201 deletions
FEB 63 additions & 21 deletions 23 additions & 25 deletions
JAN 17 additions & 21 deletions

Knowledge based on git-blame:
Jack251970: 41%

Plugins/Flow.Launcher.Plugin.Shell/Main.cs

Activity based on git-commit:

Jack251970 onesounds
JUN
MAY 6 additions & 3 deletions 5 additions & 2 deletions
APR 34 additions & 29 deletions
MAR
FEB 3 additions & 4 deletions
JAN

Knowledge based on git-blame:
Jack251970: 9%

To learn more about /:\ gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants