Settings: fix creating/editing custom shortcuts#2796
Conversation
Yusyuriv
added
bug
WalkthroughWalkthroughThe changes primarily enhance the management of custom shortcuts in Flow Launcher by integrating a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CustomShortcutSetting
participant SettingsPaneHotkeyViewModel
User ->> CustomShortcutSetting: Click 'Add Shortcut'
CustomShortcutSetting ->> SettingsPaneHotkeyViewModel: DoesShortcutExist(shortcutKey)
SettingsPaneHotkeyViewModel -->> CustomShortcutSetting: Shortcut Exists / Not Exist
CustomShortcutSetting ->> User: Display Success/Error Message
Poem
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional comments not posted (7)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
|
🥷 Code experts: VictoriousRaptor Yusyuriv has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
|
This PR is 66.66666666666666% new code. |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| } | ||
| // Check if key is modified or adding a new one | ||
| if ((update && originalKey != Key) || !update) | ||
| if (((update && originalKey != Key) || !update) && _hotkeyVm.DoesShortcutExist(Key)) |
There was a problem hiding this comment.
The logic to check for duplicate shortcuts is well-placed. However, consider adding a null check for _hotkeyVm to prevent potential runtime exceptions if the dependency is not properly injected.
if (_hotkeyVm != null && ((update && originalKey != Key) || !update) && _hotkeyVm.DoesShortcutExist(Key))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (((update && originalKey != Key) || !update) && _hotkeyVm.DoesShortcutExist(Key)) | |
| if (_hotkeyVm != null && ((update && originalKey != Key) || !update) && _hotkeyVm.DoesShortcutExist(Key)) |
onesounds
deleted the
fix-custom-shortcuts-not-working-after-settings-split
branch
3 participants
When splitting the settings window, I forgot to re-add the correct check for already existing shortcuts. It was always displaying a message saying that the shortcut already exists. This PR fixes that.
Summary by CodeRabbit
New Features
Bug Fixes