Draft
Conversation
Member
|
Would you please share a sample plugin? I couldn't see how exactly it will be. |
taooceros
reviewed
Aug 6, 2022
| protected override string Request(JsonRPCRequestModel rpcRequest, CancellationToken token = default) | ||
| { | ||
| HttpRequestMessage requestMessage = new HttpRequestMessage(HttpMethod.Post, url); | ||
| requestMessage.Content = new StringContent(rpcRequest.ToString(), Encoding.UTF8); |
Member
There was a problem hiding this comment.
I have trouble mostly with this part. It only directly use the rpcRequest as payload, which is mostly flow's style. Therefore, the use case can only be a customized http server.
I would like to see a http plugin not only provide the endpoints address, but also translate flow's query to the specific payload (a parser), and translate the response back to flow's standard response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new type of JsonRPCPlugin that retrieves results from an API endpoint that can talk the same protocol.
Not completely done. Want to configure the Http methods, etc. but wondering if this will be accepted.