Skip to content

Fix closing tab issue where the tabs are no longer returned #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

Fix closing tab issue where the tabs are no longer returned #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
324c431
add slight delay to fix re-querying after closing tab
jjw24 Aug 25, 2025
416b665
version bump
jjw24 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Main.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
{
public const string IconPath = "Images/icon.png";

private SettingWindow? SettingWindow;

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

Field 'Main.SettingWindow' is never assigned to, and will always have its default value null

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

Field 'Main.SettingWindow' is never assigned to, and will always have its default value null

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

Field 'Main.SettingWindow' is never assigned to, and will always have its default value null

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

Field 'Main.SettingWindow' is never assigned to, and will always have its default value null

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

Field 'Main.SettingWindow' is never assigned to, and will always have its default value null

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

Field 'Main.SettingWindow' is never assigned to, and will always have its default value null

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

Field 'Main.SettingWindow' is never assigned to, and will always have its default value null

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

Field 'Main.SettingWindow' is never assigned to, and will always have its default value null

Check warning on line 15 in Main.cs

View workflow job for this annotation

GitHub Actions / build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

public static PluginInitContext Context { get; private set; } = null!;

Expand Down Expand Up @@ -44,8 +44,9 @@
if (c.SpecialKeyState.CtrlPressed)
{
tab.CloseTab();
// Re-query to remove closed tab from the results
Context.API.ChangeQuery(query.RawQuery, true);
// Re-query to remove closed tab from the results.
// Add a slight delay so re-query can pick up the tab elements again, 200ms was the right amount after testing
Task.Delay(200).ContinueWith(_ => Context.API.ChangeQuery(query.RawQuery, requery: true));
}
else
tab.ActivateTab();
Expand Down
2 changes: 1 addition & 1 deletion plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"Name": "Browser Tabs",
"Description": "Search, activate, or close browser tabs. A centralized plugin for managing all open tabs in your browser",
"Author": "Jeremy Wu",
"Version": "1.0.0",
"Version": "1.0.1",
"Language": "csharp",
"Website": "https://github.com/Flow-Launcher/Flow.Launcher.Plugin.BrowserTabs",
"ExecuteFileName": "Flow.Launcher.Plugin.BrowserTabs.dll",
Expand Down
Loading