Skip to content

Commit

Permalink
Fix SILENT_BUILD_FLAG in tasks.sh
Browse files Browse the repository at this point in the history
When using := to assign to a variable in Bash, it tests for a parameter
that is unset or null. The empty string counts as null, so if I set
SILENT_BUILD_FLAG="" to make the build verbose this assignment will
still override it and make the build silent because Bash treats an emtpy
string as "null".
  • Loading branch information
FlorentRevest committed Nov 26, 2024
1 parent a3df3c4 commit 1177f14
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tasks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ done
: ${WORKSPACE_DIR:=`realpath -s "${SCRIPT_DIR}/.."`}
: ${MAKE:="make -j`nproc` LLVM=1 LLVM_IAS=1 CC='ccache clang'"}
: ${TARGET_ARCH:="x86_64"}
: ${SILENT_BUILD_FLAG:="-s"}
: ${SILENT_BUILD_FLAG="-s"}
: ${SUCCESSFUL_EXIT_COMMAND:=""}
: ${BPF_SELFTESTS_DIR:="${WORKSPACE_DIR}/tools/testing/selftests/bpf"}
: ${VM_START_ARGS:=''}
Expand Down

0 comments on commit 1177f14

Please sign in to comment.