Fix stable id collisions and provide alternate for optimiseForInsertDeleteAnimations #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
naqvitalha
changed the title
|
@muskeinsingh Please help review this |
|
How can I use the new feature prepareForLayoutAnimationRender? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes:
optimiseForInsertAndDeleteAnimationswasn't really serving any purpose because even with it turned on insert animations were broken as you'd see items flying from the recycle pool and similarly for delete animations things would fly out to be reused. This props is a no op now and deprecated in favour ofprepareForLayoutAnimationRenderapi that needs to be called along withLayoutAnimation.configureNext