Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined index while rendering sticky #674

Merged
merged 4 commits into from
Jan 27, 2022
Merged

Undefined index while rendering sticky #674

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1020852
undefined check added in render sticky
naqvitalha Jan 5, 2022
f1fc1f6
lint fix
naqvitalha Jan 5, 2022
5439787
Merge branch 'master' into undefinedIndex
naqvitalha Jan 5, 2022
114b124
Merge branch 'master' into undefinedIndex
naqvitalha Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/core/sticky/StickyObject.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,16 +230,19 @@ export default abstract class StickyObject<P extends StickyObjectProps> extends
}

private _renderSticky(): JSX.Element | JSX.Element[] | null {
const _stickyData: any = this.props.getDataForIndex(this.currentStickyIndex);
const _stickyLayoutType: string | number = this.props.getLayoutTypeForIndex(this.currentStickyIndex);
const _extendedState: object | undefined = this.props.getExtendedState();
const _rowRenderer: ((type: string | number, data: any, index: number, extendedState?: object)
=> JSX.Element | JSX.Element[] | null) = this.props.getRowRenderer();
if (this.props.overrideRowRenderer) {
return this.props.overrideRowRenderer(_stickyLayoutType, _stickyData, this.currentStickyIndex, _extendedState);
} else {
return _rowRenderer(_stickyLayoutType, _stickyData, this.currentStickyIndex, _extendedState);
if (this.currentStickyIndex !== undefined) {
const _stickyData: any = this.props.getDataForIndex(this.currentStickyIndex);
const _stickyLayoutType: string | number = this.props.getLayoutTypeForIndex(this.currentStickyIndex);
const _extendedState: object | undefined = this.props.getExtendedState();
const _rowRenderer: ((type: string | number, data: any, index: number, extendedState?: object)
=> JSX.Element | JSX.Element[] | null) = this.props.getRowRenderer();
if (this.props.overrideRowRenderer) {
return this.props.overrideRowRenderer(_stickyLayoutType, _stickyData, this.currentStickyIndex, _extendedState);
} else {
return _rowRenderer(_stickyLayoutType, _stickyData, this.currentStickyIndex, _extendedState);
}
}
return null;
}

private _getAdjustedOffsetY(offsetY: number): number {
Expand Down