Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making RLV render stack wait for pending offset #604

Merged
merged 6 commits into from
Apr 14, 2021
Merged

Making RLV render stack wait for pending offset #604

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9710797
Making RLV render stack wait for pending offset.
ananyachandra14 Apr 7, 2021
e8b304b
Adding new flag for pending scroll complete.
ananyachandra14 Apr 9, 2021
d0b6e0e
Storing a pending stack to be rendered after any pending scroll is co…
ananyachandra14 Apr 13, 2021
0cb66b9
Adding TODO.
ananyachandra14 Apr 13, 2021
30c74ea
Removing object assign.
ananyachandra14 Apr 14, 2021
9d34c90
Removing pending scroll complete flag.
ananyachandra14 Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions src/core/RecyclerListView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
};
private _layout: Dimension = { height: 0, width: 0 };
private _pendingScrollToOffset: Point | null = null;
private _pendingRenderStack?: RenderStack;
private _tempDim: Dimension = { height: 0, width: 0 };
private _initialOffset = 0;
private _cachedLayouts?: Layout[];
Expand Down Expand Up @@ -392,15 +393,21 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends

private _processInitialOffset(): void {
if (this._pendingScrollToOffset) {
const offset = this._pendingScrollToOffset;
this._pendingScrollToOffset = null;
if (this.props.isHorizontal) {
offset.y = 0;
} else {
offset.x = 0;
}
setTimeout(() => {
this.scrollToOffset(offset.x, offset.y, false);
if (this._pendingScrollToOffset) {
const offset = this._pendingScrollToOffset;
this._pendingScrollToOffset = null;
if (this.props.isHorizontal) {
offset.y = 0;
} else {
offset.x = 0;
}
this.scrollToOffset(offset.x, offset.y, false);
if (this._pendingRenderStack) {
this._renderStackWhenReady(this._pendingRenderStack);
this._pendingRenderStack = undefined;
}
}
}, 0);
}
}
Expand Down Expand Up @@ -524,6 +531,12 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
}

private _renderStackWhenReady = (stack: RenderStack): void => {
// TODO: Flickers can further be reduced by setting _pendingScrollToOffset in constructor
// rather than in _onSizeChanged -> _initTrackers
if (this._pendingScrollToOffset) {
this._pendingRenderStack = stack;
return;
}
if (!this._initStateIfRequired(stack)) {
this.setState(() => {
return { renderStack: stack };
Expand Down