Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added On Recreate Params in default export #231

Merged
merged 2 commits into from
Aug 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "recyclerlistview",
"version": "1.4.0-beta.13",
"version": "1.4.0-beta.14",
"description": "The listview that you need and deserve. It was built for performance, uses cell recycling to achieve smooth scrolling.",
"main": "dist/reactnative/index.js",
"types": "dist/reactnative/index.d.ts",
Expand Down Expand Up @@ -46,6 +46,7 @@
"devDependencies": {
"@types/lodash.debounce": "4.0.3",
"@types/prop-types": "15.5.2",
"@types/react-native": "0.49.5"
"@types/react-native": "0.49.5",
"@types/react": "16.4.7"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should provide a specific version of react types as react native types has them as dependencies. The build was breaking because it pointed to the latest version of types/react.

}
}
8 changes: 4 additions & 4 deletions src/core/RecyclerListView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ const IS_WEB = !Platform || Platform.OS === "web";
*/

//#if [WEB]
// import ScrollComponent from "../platform/web/scrollcomponent/ScrollComponent";
// import ViewRenderer from "../platform/web/viewrenderer/ViewRenderer";
// import { DefaultWebItemAnimator as DefaultItemAnimator} from "../platform/web/itemanimators/DefaultWebItemAnimator";
// const IS_WEB = true;
//import ScrollComponent from "../platform/web/scrollcomponent/ScrollComponent";
//import ViewRenderer from "../platform/web/viewrenderer/ViewRenderer";
//import { DefaultWebItemAnimator as DefaultItemAnimator} from "../platform/web/itemanimators/DefaultWebItemAnimator";
//const IS_WEB = true;
//#endif

const refreshRequestDebouncer = debounce((executable: () => void) => {
Expand Down
4 changes: 2 additions & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import ContextProvider from "./core/dependencies/ContextProvider";
import DataProvider from "./core/dependencies/DataProvider";
import { LayoutProvider, BaseLayoutProvider, Dimension } from "./core/dependencies/LayoutProvider";
import RecyclerListView from "./core/RecyclerListView";
import RecyclerListView, { OnRecreateParams } from "./core/RecyclerListView";
import BaseScrollView from "./core/scrollcomponent/BaseScrollView";
import { BaseItemAnimator } from "./core/ItemAnimator";
import { AutoScroll } from "./utils/AutoScroll";
import { LayoutManager, WrapGridLayoutManager, Point, Layout } from "./core/layoutmanager/LayoutManager";
import ProgressiveListView from "./core/ProgressiveListView";

export {
ContextProvider,
DataProvider,
Expand All @@ -23,4 +22,5 @@ export {
Dimension,
Point,
Layout,
OnRecreateParams,
};