fix for scroll to offset api #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naqvitalha
reviewed
Jul 26, 2018
src/core/RecyclerListView.tsx
Outdated
| @@ -304,7 +300,7 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends | |||
|
|
|||
| public getCurrentScrollOffset(): number { | |||
| const viewabilityTracker = this._virtualRenderer.getViewabilityTracker(); | |||
| return viewabilityTracker ? viewabilityTracker.getLastOffset() : 0; | |||
| return (viewabilityTracker ? viewabilityTracker.getLastOffset() : 0) + this.props.distanceFromWindow!; | |||
There was a problem hiding this comment.
If think it should be 0 if viewability tracker is unavailable otherwise without doing anything there will be a non zero offset.
There was a problem hiding this comment.
Also, minimum offset for viewability tracker is zero. Thus this should only be attributed if lastOffset > distanceFromWindow
Adding distanceFromWindow to currentOffset only if viewability tracker’s offset is geater than distanceFromWindow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.