Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed all binds #216

Merged
merged 5 commits into from
Jul 19, 2018
Merged

removed all binds #216

merged 5 commits into from
Jul 19, 2018

Conversation

manishPatwari
Copy link
Collaborator

No description provided.

@@ -148,13 +148,6 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends

constructor(props: P) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also add context as the second option param?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@muskeinsingh
Copy link
Contributor

@manishPatwari CI test it failing. Can you fix that?

Copy link
Collaborator

@naqvitalha naqvitalha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naqvitalha naqvitalha merged commit 3a25674 into master Jul 19, 2018
@naqvitalha naqvitalha deleted the perf branch July 19, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants