accomodating content insets and content container padding in visible … #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naqvitalha
requested changes
Jun 12, 2018
src/core/RecyclerListView.tsx
Outdated
| @@ -107,7 +107,7 @@ export interface RecyclerListViewProps { | |||
|
|
|||
| //For all props that need to be proxied to inner/external scrollview. Put them in an object and they'll be spread | |||
| //and passed down. For better typescript support. | |||
| scrollViewProps?: object; | |||
| scrollViewProps?: ScrollViewProperties; | |||
There was a problem hiding this comment.
Web build will fail here
src/core/RecyclerListView.tsx
Outdated
| @@ -314,6 +316,26 @@ export default class RecyclerListView extends React.Component<RecyclerListViewPr | |||
| // rowRenderer, | |||
| // ...props, | |||
| // } = this.props; | |||
|
|
|||
| if (!this._derivedContentInsets && this.props.scrollViewProps) { | |||
There was a problem hiding this comment.
Make a utility and move to componentWillReceiveProps.
Render is called multiple times in recyclerview internally.
src/core/RecyclerListView.tsx
Outdated
| @@ -40,7 +40,7 @@ import ItemAnimator, { BaseItemAnimator } from "./ItemAnimator"; | |||
| import ScrollComponent from "../platform/reactnative/scrollcomponent/ScrollComponent"; | |||
| import ViewRenderer from "../platform/reactnative/viewrenderer/ViewRenderer"; | |||
| import { DefaultJSItemAnimator as DefaultItemAnimator } from "../platform/reactnative/itemanimators/defaultjsanimator/DefaultJSItemAnimator"; | |||
| import { Platform } from "react-native"; | |||
| import { Platform, ScrollViewProperties, Insets } from "react-native"; | |||
There was a problem hiding this comment.
Define this type yourself
There was a problem hiding this comment.
Is this type also not available for web?
naqvitalha
reviewed
Jun 12, 2018
src/core/RecyclerListView.tsx
Outdated
| if (!this._derivedContentInsets && this.props.scrollViewProps) { | ||
| this._derivedContentInsets = this.props.scrollViewProps.contentInset ? this.props.scrollViewProps.contentInset : { top: 0, left: 0, right: 0, bottom: 0 }; | ||
|
|
||
| if (this.props.scrollViewProps.contentContainerStyle) { |
There was a problem hiding this comment.
contentContainerStyle can also come in props
naqvitalha
reviewed
Jun 13, 2018
src/core/RecyclerListView.tsx
Outdated
| * Use this prop to provide padding around list content instead of | ||
| * using padding/margin in contentContainerStyle prop of scroll view. | ||
| */ | ||
| contentInsets?: EdgeInsets; |
There was a problem hiding this comment.
Won't this conflict with existing ScrollView prop?
There was a problem hiding this comment.
Can we just take paddingTop etc directly which we can override in give contentContainerStyle.
Also will need to be handled in web version
src/core/RecyclerListView.tsx
Outdated
| @@ -319,6 +335,14 @@ export default class RecyclerListView extends React.Component<RecyclerListViewPr | |||
| ref={(scrollComponent) => this._scrollComponent = scrollComponent as BaseScrollComponent | null} | |||
| {...this.props} | |||
| {...this.props.scrollViewProps} | |||
| {...{ | |||
| contentContainerStyle: { | |||
| paddingTop: this._contentInsets.top, | |||
src/core/RecyclerListView.tsx
Outdated
| @@ -319,6 +335,14 @@ export default class RecyclerListView extends React.Component<RecyclerListViewPr | |||
| ref={(scrollComponent) => this._scrollComponent = scrollComponent as BaseScrollComponent | null} | |||
| {...this.props} | |||
| {...this.props.scrollViewProps} | |||
| {...{ | |||
| contentContainerStyle: { | |||
There was a problem hiding this comment.
Let's resolve conflicts if dev already sends this prop
Using existing prop to deal with padding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…row calculations