Remove no data warning (#711)

* remove unnecessary force refresh

* Removed NO DATA warning

Co-authored-by: Talha Naqvi <talha.naqvi@shopify.com>

src/core/RecyclerListView.tsx

@@ -234,9 +234,6 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
         this._processInitialOffset();
         this._processOnEndReached();
         this._checkAndChangeLayouts(this.props);
-        if (this.props.dataProvider.getSize() === 0) {
-            console.warn(Messages.WARN_NO_DATA); //tslint:disable-line
-        }
         this._virtualRenderer.setOptimizeForAnimations(false);
     }
 

src/core/constants/Constants.ts

@@ -1,4 +1,4 @@
-export const Constants: {[key: string]: string} = {
+export const Constants = {
     CONTEXT_PROVIDER_OFFSET_KEY_SUFFIX : "_offset",
     CONTEXT_PROVIDER_LAYOUT_KEY_SUFFIX: "_layouts",
 };

src/core/constants/Messages.ts

@@ -1,8 +1,6 @@
-export const Messages: {[key: string]: string} = {
+export const Messages = {
     ERROR_LISTVIEW_VALIDATION : "missing datasource or layout provider, cannot proceed without it",
     WARN_SCROLL_TO_INDEX: "scrollTo was called before RecyclerListView was measured, please wait for the mount to finish",
-    WARN_NO_DATA: "You have mounted RecyclerListView with an empty data provider (Size in 0). Please mount only if there is atleast one item " +
-                  "to ensure optimal performance and to avoid unexpected behavior",
     VISIBLE_INDEXES_CHANGED_DEPRECATED: "onVisibleIndexesChanged deprecated. Please use onVisibleIndicesChanged instead.",
     ANIMATION_ON_PAGINATION: "Looks like you're trying to use RecyclerListView's layout animation render while doing pagination. " +
                              "This operation will be ignored to avoid creation of too many items due to developer error.",