removed no-op set state (#703)

Co-authored-by: Talha Naqvi <talha.naqvi@shopify.com>
Flipkart · Mar 29, 2022 · 3d581db · 3d581db
1 parent ca0e89a
commit 3d581db
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/core/RecyclerListView.tsx b/src/core/RecyclerListView.tsx
@@ -147,6 +147,7 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
     private _virtualRenderer: VirtualRenderer;
     private _onEndReachedCalled = false;
     private _initComplete = false;
+    private _isMounted = true;
     private _relayoutReqIndex: number = -1;
     private _params: RenderStackParams = {
         initialOffset: 0,
@@ -242,6 +243,7 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
     }
 
     public componentWillUnmount(): void {
+        this._isMounted = false;
         if (this.props.contextProvider) {
             const uniqueKey = this.props.contextProvider.getUniqueKey();
             if (uniqueKey) {
@@ -546,9 +548,11 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends
 
     private _queueStateRefresh(): void {
         this.refreshRequestDebouncer(() => {
-            this.setState((prevState) => {
-                return prevState;
-            });
+            if (this._isMounted) {
+                this.setState((prevState) => {
+                    return prevState;
+                });
+            }
         });
     }