Switch API to support composite listeners #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did the Travis build on this? |
|
I think @SamThompson set it up to build on PRs |
added 3 commits
November 22, 2015 22:23
apparently this is required now per travis-ci/travis-ci#5036
Not sure why this passes locally and fails on CI, this should help shed some light
Should fix API lint errors on CI
|
Yes, I enabled it so we know if the PR builds successfully and aren't accidentally merging stuff that breaks the build. This verification can be done manually, but I think it's more convenient for Travis to do it for us. I'd concede that it gets a tad annoying to deal with at times, though. |
|
Ok, looks good. |
ZacSweers
added a commit
that referenced
this pull request
Nov 24, 2015
Switch API to support composite listeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #75