-
Notifications
You must be signed in to change notification settings - Fork 45
Two UX improvements on the 2FA form #1875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Documentation build overview
Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
|
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
|
Although a different approach was mentioned in the issue, I believe this design would be better. We don't have to create an extra page for the other form(as its a pretty small component), it can still be left here and can be visible on command. |
nhoening
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but you reverted my work, why?
Also, have you tested if this works on a mobile device? I see you used data-bs-toggle="collapse" so that is a good, stable choice and I expect it would, but let's be sure.
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
I tested this and it works fine |
nhoening
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found something that requires some extra attention ...
Co-authored-by: Nicolas Höning <nicolas@seita.nl> Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
…res into ui/nicer-2FA-form
Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>
Description
Implement two UX improvements on the 2FA form, which we found in a user test.
Closes #1761
See that issue for other suggestions which we are not tackling here.
Look & Feel
Before:
After:

TODO
documentation/changelog.rst