Skip to content

Fix/scheduling/sign #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Flix6x wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix/scheduling/sign #1348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f78f51e
docs: clarify inline comment
Flix6x Mar 2, 2025
32f92c3
fix: the sign should be switched if consumption is positive, and the …
Flix6x Mar 2, 2025
ea72f0d
Merge remote-tracking branch 'refs/remotes/origin/main' into fix/sche…
Flix6x Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions flexmeasures/api/v3_0/sensors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,12 +940,12 @@ def get_schedule( # noqa: C901
)

sign = 1
if sensor.measures_power and sensor.get_attribute(
"consumption_is_positive", True
if sensor.measures_power and not sensor.get_attribute(
"consumption_is_positive", False
):
sign = -1

# For consumption schedules, positive values denote consumption. For the db, consumption is negative
# For consumption schedules, positive values denote consumption. For the db, consumption is negative unless specified explicitly
consumption_schedule = sign * simplify_index(power_values)["event_value"]
if consumption_schedule.empty:
return unknown_schedule(
Expand Down
4 changes: 2 additions & 2 deletions flexmeasures/data/services/scheduling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,8 +625,8 @@ def make_schedule(

sign = 1

if result["sensor"].measures_power and result["sensor"].get_attribute(
"consumption_is_positive", True
if result["sensor"].measures_power and not result["sensor"].get_attribute(
"consumption_is_positive", False
):
sign = -1

Expand Down