Feature: File encryption #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perfectmak
force-pushed
the
feature/file-encryption
branch
from
4427ed3 to
c0b3d7f
Compare
jsonsivar
approved these changes
Feb 28, 2021
| */ | ||
| public read8(): number { | ||
| const value = this.dataView.getUint8(this.bytePositon); | ||
| this.bytePositon += 1; |
There was a problem hiding this comment.
Does this not need the endian value?
There was a problem hiding this comment.
No it doesn't. Since endianness affects layout of each consecutive byte blocks so a simple 8bit read (1 byte) would always be in the correct order.
There was a problem hiding this comment.
Got it, that makes, thank you. Was wondering if it was by bit 😅
perfectmak
force-pushed
the
feature/file-encryption
branch
from
c9259a4 to
7b9d07c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds upload encryption and open file decryption.
Note: This makes a notable change to how daemon used to do encryption, instead of a bucket having a single encryption key for all files, each file now has its own encryption key. And only this key is shared with users when the file is shared.
Type of change
How Has This Been Tested?
Checklist: