Skip to content

Fix: Fetch Members of ShareFiles #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2021
Merged

Fix: Fetch Members of ShareFiles #64

merged 1 commit into from
Feb 27, 2021

Conversation

perfectmak
Copy link
Contributor

@perfectmak perfectmak commented Feb 27, 2021 •
edited
Loading

Description

Fix empty members list in shared file entries

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Test
  • Integration Test

Checklist:

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@perfectmak perfectmak force-pushed the fix/addMembers-to-shared-with-me branch from 1a1faf5 to ce4fc93 Compare February 27, 2021 19:35
gpuente
gpuente approved these changes Feb 27, 2021
View reviewed changes
Copy link

@gpuente gpuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perfectmak perfectmak force-pushed the fix/addMembers-to-shared-with-me branch from ce4fc93 to 8ab7831 Compare February 27, 2021 20:29
@perfectmak perfectmak merged commit 9c22394 into master Feb 27, 2021
@perfectmak perfectmak deleted the fix/addMembers-to-shared-with-me branch February 27, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpuente gpuente gpuente approved these changes

@jsonsivar jsonsivar Awaiting requested review from jsonsivar

Assignees

@jsonsivar jsonsivar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perfectmak @gpuente @jsonsivar