Skip to content

Hotfix: convert pub key for members. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

jsonsivar
Copy link
Contributor

Description

Hotfix that converts pub keys on DirectoryEntry members so that it matches the format stored in identity sevice.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Test
  • Integration Test

Checklist:

  • My code follows the style guidelines of this project
  • [] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@perfectmak perfectmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maybe we should consider creating a util function of the Buffer.from(tryParsePublicKey(pubkey).pubKey).toString('hex') so we don't have to be repeating that long function everywhere

@perfectmak perfectmak merged commit 3b7c176 into master Feb 26, 2021
@perfectmak perfectmak deleted the hotfix/listdir/correct-pubkey branch February 26, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants