Skip to content

Feature: Implement UserStorage.syncFromTempKey #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

perfectmak
Copy link
Contributor

Description

This PR provides the actual implementation for UserStorage.syncFromTempKey().
It also does some internal refactoring of some user authentication process to allow authentication of temp key user in order to sync.

It is ready for review, but still under testing

Fixes: ch21507

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Test
  • Integration Test

Checklist:

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #21507: Create identity from temp key.

@perfectmak perfectmak force-pushed the feature/ch21507/syncStorageFromTempKey branch 3 times, most recently from ce83769 to ca47834 Compare February 26, 2021 10:49
@perfectmak perfectmak force-pushed the feature/ch21507/syncStorageFromTempKey branch from ca47834 to cc5f46b Compare February 26, 2021 11:01
@perfectmak perfectmak merged commit 977dd73 into master Feb 26, 2021
@perfectmak perfectmak deleted the feature/ch21507/syncStorageFromTempKey branch February 26, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants