Move paths: move paths sdk method with commented out textile call #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #21555: SDK: Move. |
perfectmak
approved these changes
Feb 25, 2021
packages/storage/src/userStorage.ts
Outdated
| client: Buckets, | ||
| bucket: BucketMetadataWithThreads, | ||
| emitter: ee.Emitter, | ||
| ) { |
There was a problem hiding this comment.
Suggested change
| ) { | |
| ): Promise<MovePathsResultSummary> { |
|
Hey @perfectmak - can you kindly review the latest commit on this. There were some more changes needed after last review. It's working against dev hub now so we can do a quick review and then I can release. |
perfectmak
approved these changes
Mar 11, 2021
… be uncommented when txl pkg is released).
jsonsivar
force-pushed
the
feature/ch21555/move
branch
from
f663ef9 to
def362a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements the move paths on the SDK. It will take an array of source paths and an array of destination paths and line them up by index and perform the move. It will then produce an event in the returned event emitter for each move operation and then a finally summary with the count of move operations in the end.
Fixes # (issue)
https://app.clubhouse.io/terminalsystems/story/21555/sdk-move
Type of change
How Has This Been Tested?
NOTE: pending Textile release for true integration test.
Checklist: