setNotificationsLastSeenAt and add the value to getNotifications call #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #21022: SetNotificationsLastSeenAt. |
perfectmak
approved these changes
Feb 24, 2021
| const encryptedTimestamp = await this.encrypt(timestamp.toString()); | ||
| const lookupKey = this.getNotificationsLastSeenAtLookupKey(); | ||
| const nodeRef = this.lookupUser.get(lookupKey).put({ data: encryptedTimestamp }); | ||
| this.listUser.get(NotificationsLastSeenAtCollection).set(nodeRef as unknown as EncryptedMetadata); |
There was a problem hiding this comment.
I don't think you need to add it to a set() here. The set is useful if we need a list of all last seen at timestamp right? And I don't think we would need that. We are only interested in setting and getting that data right? So the put() should be fine. It would always override the latest value.
| @@ -478,6 +499,10 @@ export class GundbMetadataStore implements UserMetadataStore { | |||
| }); | |||
| } | |||
|
|
|||
| private getNotificationsLastSeenAtLookupKey(): string { | |||
| return `notifications/lastSeenAt/${this.username}`; | |||
There was a problem hiding this comment.
Suggested change
| return `notifications/lastSeenAt/${this.username}`; | |
| return `notifications/lastSeenAt`; |
Since the key already namespaced to the user, we shouldn't need to add the username field to the lookup key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
setNotificationsLastSeenAtso the FE can set it. And alsogetNotificationsnow returns this value properly.https://app.clubhouse.io/terminalsystems/story/21022/setnotificationslastseenat
Type of change
How Has This Been Tested?
Checklist: