Skip to content

Feature: Implement handleFileInvitation for rejecting invitation #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

perfectmak
Copy link
Contributor

Description

This PR properly implements accepting and rejecting file invitations.
It also does some internal logic to update the notifications for a user based on the action performed on the invite.

Fixes [ch21018]

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change: The previously public acceptInvitation() method has been removed.

How Has This Been Tested?

  • Unit Test
  • Integration Test

Checklist:

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #21018: HandleFilesInvitation.

@perfectmak perfectmak force-pushed the feature/ch21018/handeFileInvitation branch 5 times, most recently from 7d79992 to 6af398f Compare February 19, 2021 19:30
@perfectmak perfectmak force-pushed the feature/ch21018/handeFileInvitation branch from 6af398f to 817c521 Compare February 19, 2021 19:46
@perfectmak perfectmak merged commit 3cd569c into master Feb 19, 2021
@perfectmak perfectmak deleted the feature/ch21018/handeFileInvitation branch February 19, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants