Skip to content

Hotfix: init if mailbox is not set #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2021
Merged

Conversation

jsonsivar
Copy link
Contributor

Description

This change double checks if the mailbox field is set on the SDK and init's it if it is not found. Even though the FE was initalizing it, for some reason the mailbox field was null so it was not sending the mails. This is a workaround so it re-inits it. @perfectmak let me know if you spot anything that could be the underlying issue.

Sidenote: also updated integration tests so we can test on dev via env vars as needed.

Fixes # (issue)
Mail not sending during share.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Test
  • Integration Test

Checklist:

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@perfectmak perfectmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems the tests are a failing due to the new TXL_HUB_URL environment variable

@jsonsivar jsonsivar merged commit ad82868 into master Feb 19, 2021
@perfectmak perfectmak deleted the hotfix/notifs/dbl-check-init branch March 19, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants