fix(csv-to-json): copy to clipboard is not working #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyfirman
changed the title
dboskovic
approved these changes
Aug 8, 2022
Collaborator
|
Thanks for this contribution! |
Author
|
Thanks for the approval @dboskovic , this is my first open-source PR. Glad to know it has been merged. Please let me know if it has been deployed, can't wait to see my changes on the production. 🙂 |
Contributor
|
@fyfirman thanks for you PR! The change has been deployed and ready to check out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #140
Description
Regarding to this document,
document.execCommandis deprecated and it is not recommended to use. I changed it with the Clipboard API that support most modern browser. However, I created the fallback if the browser does not support Clipboard API to usedocument.execCommandVideos
fixed-copy-to-clipboard.mov
Other Information
Tested on Chrome 104 on macOS (Monterey)