Repository navigation
Conversation
…g API Only the features owning system segments can change their overrides now, by calling update_flag or delete_segment_override with system=True. Writing them as they are, e.g. replacing a flag as read, still works.
Superseded by the /api/__future__/ flag endpoints, documented at https://docs.flagsmith.com/managing-flags/updating-flags. Removes /api/experiments/environments/{key}/update-flag-v1/, update-flag-v2/ and delete-segment-override/.
The create-segment-override, feature-segments and featurestates endpoints now write live segment overrides through features.future.services, keeping their requests and responses. They refuse system segment changes with it.
update-priorities reorders live overrides through the flag API, moving the others out of the way as before. Writes the flag API can't make, e.g. to drafts, refuse system segments until #7641. Committing a change request refuses changes to system segments.
Also refuses create-segment-override requests without a feature segment with a 400, rather than erroring.
SegmentSerializer refuses drafting versions of system segments, which also covers the change request serializers extending it, rather than waiting for their commit.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
api
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8713 +/- ##
==========================================
- Coverage 98.85% 98.84% -0.01%
==========================================
Files 1665 1667 +2
Lines 68762 68689 -73
==========================================
- Hits 67972 67893 -79
- Misses 790 796 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
POST feature-segments/ in v2 environments drafts feature segments for the feature states of new versions, e.g. ones going through change requests, rather than overriding the live flag.
- Type the legacy feature state data validated by the legacy APIs. - Move the legacy override writes, and code reference notifications, to features/services.py. - Render APIErrorDetail bodies from a common APIError base class. - Mark legacy viewsets for removal as a whole.
github-actions
Bot
added
docs
The legacy APIs clear values themselves, without v2 feature versioning, so the flag API keeps its request types. Legacy segment override helpers move to features/feature_segments.
Creating overrides enabled or not already keeps their audit log to one entry, without comparing their values.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
WIP
Contributes to #8608
How did you test this code?
Please describe.