Skip to content

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Oct 7, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Places the associated features page with the following

image

Opening a feature from this view simply opens the feature modal with the segment overrides tab selected.

How did you test this code?

Requires #6156

  • Create some segment overrides
  • View this page and validate that segment overrides are highlighted

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 7, 2025 21:59
@kyle-ssg kyle-ssg requested review from Zaimwa9 and removed request for a team October 7, 2025 21:59
@vercel
Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Comment Nov 18, 2025 1:20pm
flagsmith-frontend-staging Ready Ready Preview Comment Nov 18, 2025 1:20pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Nov 18, 2025 1:20pm

@kyle-ssg kyle-ssg marked this pull request as draft October 7, 2025 21:59
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Oct 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6137 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6137 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-6137 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6137 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6137 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6137 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6137 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6137 Finished ✅ Results

@github-actions github-actions bot removed the feature New feature or request label Oct 21, 2025
@kyle-ssg kyle-ssg requested a review from Zaimwa9 November 11, 2025 19:44
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and unfortunately it doesn't work. See the screen recording below. It looks like when you try to update a feature for a given segment, it's making a call to update it for an identity.

I would expect it to add a segment override for this segment (and include that information in the confirmation modal).

segment-features-page-bug.mov

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Nov 16, 2025

Ah, ok yes this didn't consider toggling the switch directly vs opening the modal. I think for simplicity sake clicking any part of the row should just open up the segment override tab. I've updated this.

We could have that automatically add an override to the list though I'm not sure it's a good idea, creating an override at the point where you can see others / set priority is more simple and makes sense. When I use Flagsmith even on fairly simple projects I'd never want to add a segment override without seeing the full context (other segment overrides for this feature).

Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, small change

…ent-feature-state-view

# Conflicts:
#	frontend/common/stores/feature-list-store.ts
#	frontend/web/components/modals/AssociatedSegmentOverrides.js
#	frontend/web/components/segments/Rule/components/RuleConditionValueInput.tsx
@matthewelwell
Copy link
Contributor

Ah, ok yes this didn't consider toggling the switch directly vs opening the modal. I think for simplicity sake clicking any part of the row should just open up the segment override tab. I've updated this.

We could have that automatically add an override to the list though I'm not sure it's a good idea, creating an override at the point where you can see others / set priority is more simple and makes sense. When I use Flagsmith even on fairly simple projects I'd never want to add a segment override without seeing the full context (other segment overrides for this feature).

Yeah, I guess this makes sense with the current functionality. It is quite annoying to have to find the segment in the list still after clicking the row though. I wonder if there's an option here to add an extra step to creating a segment override which adds a confirmation button next to the drop down in the modal, then we could pre-fill the drop down when you click the row? Maybe that's overkill, but I do feel that the UX here is a little janky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants