Skip to content

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 1, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Closes #6121, #6120.

In this PR, we:

  • Remove the EvaluationResult.context property.
  • Switch EvaluationResult.flags to a map of feature names to flag objects.
    These changes are breaking and should be addressed in engine implementations and SDKs.

How did you test this code?

The SDKs codegen will be run against the branch.

@khvn26 khvn26 requested a review from a team as a code owner October 1, 2025 09:23
@khvn26 khvn26 requested review from Zaimwa9 and removed request for a team October 1, 2025 09:23
@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Oct 1, 2025 11:31am
flagsmith-frontend-preview Ignored Ignored Preview Oct 1, 2025 11:31am
flagsmith-frontend-staging Ignored Ignored Preview Oct 1, 2025 11:31am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6124 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6124 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6124 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6124 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6124 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6124 Finished ✅ Results

@github-actions github-actions bot added the chore label Oct 1, 2025
@khvn26 khvn26 merged commit bea70c9 into main Oct 3, 2025
25 checks passed
@khvn26 khvn26 deleted the chore/improve-evaluation-result branch October 3, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Context Values: Make EvaluationResult.flags a dictionary

3 participants