Skip to content

Chore: componentise feature override row #5920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: feat/segment-page
Choose a base branch
from

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Migrates identity page feature row to a typescript component. This allows us to:

  • Get further reuse from feature row components
  • Standardise the way we show features
  • Makes the work to show feature deltas for a segment a lot more straight forward

How did you test this code?

  • Test MV, segment and user overrides
  • E2E cover a lot of this

@kyle-ssg kyle-ssg requested review from a team as code owners August 12, 2025 13:00
@kyle-ssg kyle-ssg requested review from tiagoapolo and Zaimwa9 and removed request for a team August 12, 2025 13:00
Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
flagsmith-frontend-preview Ready Preview Comment Aug 12, 2025 1:01pm
flagsmith-frontend-staging Ready Preview Comment Aug 12, 2025 1:01pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs ⬜️ Ignored Aug 12, 2025 1:01pm

Copy link
Contributor

github-actions bot commented Aug 12, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5920 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5920 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5920 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5920 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5920 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5920 Finished ✅ Results

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (94bea60) to head (df8de68).
⚠️ Report is 520 commits behind head on feat/segment-change-requests.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feat/segment-change-requests    #5920      +/-   ##
================================================================
+ Coverage                         97.39%   97.82%   +0.43%     
================================================================
  Files                              1191     1258      +67     
  Lines                             41552    44846    +3294     
================================================================
+ Hits                              40470    43872    +3402     
+ Misses                             1082      974     -108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kyle-ssg kyle-ssg changed the title Chore/componentise feature override row Chore: componentise feature override row Aug 12, 2025
@kyle-ssg kyle-ssg marked this pull request as draft August 12, 2025 13:08
@kyle-ssg kyle-ssg changed the base branch from feat/segment-change-requests to main August 12, 2025 13:09
@kyle-ssg kyle-ssg removed request for a team, tiagoapolo and Zaimwa9 August 12, 2025 13:09
@kyle-ssg kyle-ssg changed the base branch from main to feat/segment-page August 12, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API docs Documentation updates front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant