Skip to content

feat: Release Pipeline Publish and Add Flag #5542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 25, 2025

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Jun 5, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Ref: #5301
#5275

Implements:

  • Publishing release pipeline, changes release pipeline from draft to published
  • Adding a feature flag to published pipeline
Screenshot 2025-06-05 at 10 13 35 Screenshot 2025-06-05 at 10 13 54 Screenshot 2025-06-05 at 10 14 17 Screenshot 2025-06-05 at 10 14 43

How did you test this code?

⚠️ Tested using branch containing backend and frontend release-pipe-publish-back-front

@tiagoapolo tiagoapolo requested a review from a team as a code owner June 5, 2025 12:55
@tiagoapolo tiagoapolo requested review from Zaimwa9 and removed request for a team June 5, 2025 12:55
Copy link

vercel bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 2:31pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 2:31pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2025 2:31pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jun 5, 2025
@tiagoapolo tiagoapolo changed the base branch from main to feat/release-pipeline-wait-for-trigger June 5, 2025 12:55
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5542 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5542 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5542 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5542 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5542 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5542 Finished ✅ Results

@tiagoapolo tiagoapolo force-pushed the feat/release-pipeline-wait-for-trigger branch 3 times, most recently from b3cac16 to fca49cd Compare June 12, 2025 11:09
@tiagoapolo tiagoapolo force-pushed the feat/release-pipeline-publish branch from a7f0e33 to 013dd7e Compare June 12, 2025 11:34
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 12, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 13, 2025
@tiagoapolo tiagoapolo force-pushed the feat/release-pipeline-wait-for-trigger branch from 1888f3c to c969a52 Compare June 16, 2025 17:40
@tiagoapolo tiagoapolo force-pushed the feat/release-pipeline-publish branch from e0fb848 to 73dbff1 Compare June 16, 2025 18:48
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 16, 2025
@tiagoapolo tiagoapolo requested review from Zaimwa9 and kyle-ssg June 24, 2025 19:45
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go, 2 things to solve before ✅ :

  • The update of a stage removing the following stages
  • The catch on getReleasePipelines

We can create a ticket to properly deal with enterprise

@@ -124,7 +124,7 @@ const CreatePipelineStage = ({
if (action.action_type === StageActionType.TOGGLE_FEATURE_FOR_SEGMENT) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm adding here some comments about something I didn't notice => Non-enteprise orgs.

  • The release pipelines nav item is available (I would personally disable it and adding a tooltip to warn it's for enterprise but tbd with product)
  • You have access to the whole flow and only get the error at the end
  • The failure message is success and not error

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be out of this PR scope so maybe we can create a ticket specifically to address the non available state of this feature

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have this in the organisation payload:

{
  "id": 2,
  "has_active_billing_periods": true,
  "deleted_at": null,
  "uuid": "xxxx",
  "subscription_id": "123",
  "subscription_date": null,
  "plan": "enterprise",
  "max_seats": 400,
  "max_api_calls": 50000,
  "cancellation_date": null,
  "customer_id": null,
  "billing_status": null,
  "payment_method": null,
  "notes": null
}

In the context of release, the backend definition of enterprise is:
!!subscription_id && !is_cancellation_date && plan === 'enterprise, to see if it exactly matches the frontend one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be handled in a separate ticket

}

const handleRemoveStage = (index: number) => {
const newStages = stages.filter((_, i) => i !== index)
setStages(newStages)
const newStages = pipelineData.stages.filter((_, i) => i !== index)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-opening as this one hasn't been resolved

https://www.loom.com/share/81069cfa500747b19e88aef5c5dbf753

Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tiagoapolo tiagoapolo merged commit 5b89995 into main Jun 25, 2025
25 checks passed
@tiagoapolo tiagoapolo deleted the feat/release-pipeline-publish branch June 25, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants