-
Notifications
You must be signed in to change notification settings - Fork 451
feat: Release Pipeline Publish and Add Flag #5542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
b3cac16
to
fca49cd
Compare
a7f0e33
to
013dd7e
Compare
1888f3c
to
c969a52
Compare
e0fb848
to
73dbff1
Compare
f52fe53
to
ddd9d63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to go, 2 things to solve before ✅ :
- The update of a stage removing the following stages
- The catch on getReleasePipelines
We can create a ticket to properly deal with enterprise
@@ -124,7 +124,7 @@ const CreatePipelineStage = ({ | |||
if (action.action_type === StageActionType.TOGGLE_FEATURE_FOR_SEGMENT) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm adding here some comments about something I didn't notice => Non-enteprise orgs.
- The release pipelines nav item is available (I would personally disable it and adding a tooltip to warn it's for enterprise but tbd with product)
- You have access to the whole flow and only get the error at the end
- The failure message is success and not error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be out of this PR scope so maybe we can create a ticket specifically to address the non available state of this feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we have this in the organisation payload:
{
"id": 2,
"has_active_billing_periods": true,
"deleted_at": null,
"uuid": "xxxx",
"subscription_id": "123",
"subscription_date": null,
"plan": "enterprise",
"max_seats": 400,
"max_api_calls": 50000,
"cancellation_date": null,
"customer_id": null,
"billing_status": null,
"payment_method": null,
"notes": null
}
In the context of release, the backend definition of enterprise is:
!!subscription_id && !is_cancellation_date && plan === 'enterprise
, to see if it exactly matches the frontend one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be handled in a separate ticket
} | ||
|
||
const handleRemoveStage = (index: number) => { | ||
const newStages = stages.filter((_, i) => i !== index) | ||
setStages(newStages) | ||
const newStages = pipelineData.stages.filter((_, i) => i !== index) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-opening as this one hasn't been resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Ref: #5301
#5275
Implements:
How did you test this code?
release-pipe-publish-back-front