feat: Send users notification when api flags have been blocked #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
api
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4338 +/- ##
=======================================
Coverage 96.83% 96.84%
=======================================
Files 1165 1166 +1
Lines 38621 38675 +54
=======================================
+ Hits 37398 37453 +55
+ Misses 1223 1222 -1 ☔ View full report in Codecov by Sentry. |
api/organisations/templates/organisations/api_flags_blocked_notification.txt
Outdated
Show resolved
Hide resolved
…on_when_api_flags_have_been_blocked
github-actions
bot
added
feature
github-actions
bot
added
feature
matthewelwell
requested changes
Jul 25, 2024
api/organisations/tasks.py
Outdated
| @@ -47,6 +42,10 @@ | |||
| STARTUP_V2, | |||
| SubscriptionCacheEntity, | |||
| ) | |||
| from .task_helpers import ( | |||
| _handle_api_usage_notifications, | |||
There was a problem hiding this comment.
This shouldn't still be a private function since we're calling it from another module now.
There was a problem hiding this comment.
Ok I've renamed it
api/organisations/task_helpers.py
Outdated
| ) | ||
|
|
||
|
|
||
| def send_api_usage_notification( |
There was a problem hiding this comment.
This probably can be a private function now?
There was a problem hiding this comment.
Sure, I've renamed it.
matthewelwell
approved these changes
Jul 25, 2024
matthewelwell
deleted the
feat/send_users_notification_when_api_flags_have_been_blocked
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously, users using the free Flagsmith plan were blocked from using the feature flagging API once they had breach the limit and grace period. With this change, users now get an email notification that their usage is now being blocked.
How did you test this code?
Added tests for the functionality to an existing long test which covered multiple of the possible scenarios.