Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Surface password requirements on signup / dynamic validation #4282

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

sumtzehern
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Added a PasswordRequirements component to the signup form to provide real-time feedback on password requirements.

How did you test this code?

I tested this code by:

  1. Running the application locally.
  2. Navigating to the signup form.
  3. Entering different passwords to verify the real-time feedback for password requirements.
  4. Ensuring all password requirement checks (length, number, special character, uppercase, and lowercase letters) work as expected.

@sumtzehern sumtzehern requested a review from a team as a code owner July 3, 2024 21:52
@sumtzehern sumtzehern requested review from kyle-ssg and removed request for a team July 3, 2024 21:52
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 8:40am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 8:40am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 8:40am

Copy link

vercel bot commented Jul 3, 2024

@sumtzehern is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Uffizzi Preview deployment-53938 was deleted.

@kyle-ssg
Copy link
Member

kyle-ssg commented Jul 8, 2024

@sumtzehern, Aesthetically this is awesome! However it looks like I was able to sign up with the following.

Discussing internally, the requirements do look sensible either way - could we adjust the PR to disable the button whilst they aren't met? Also as the image indicates, the symbol check needs adjusting.

Also maybe if you could try replacing the x and check with ionicons

import { close, checkmark } from 'ionicons/icons'
import { IonIcon } from '@ionic/react'

image

@sumtzehern
Copy link
Contributor Author

@kyle-ssg, made some changes including:

  1. Replaced x and check icons with Ionicons.
  2. Adjusted password validation to include more symbols.
  3. Disabled 'Create Account' button until requirements are met.
Screenshot 2024-07-12 at 1 49 30 PM

@kyle-ssg
Copy link
Member

Thanks so much, this looks great!

@kyle-ssg kyle-ssg added this pull request to the merge queue Jul 31, 2024
Merged via the queue into Flagsmith:main with commit 104d66d Jul 31, 2024
15 of 17 checks passed
@sumtzehern
Copy link
Contributor Author

@kyle-ssg, Awesome, Good to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants