-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Surface password requirements on signup / dynamic validation #4282
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@sumtzehern is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
Uffizzi Preview |
@sumtzehern, Aesthetically this is awesome! However it looks like I was able to sign up with the following. Discussing internally, the requirements do look sensible either way - could we adjust the PR to disable the button whilst they aren't met? Also as the image indicates, the symbol check needs adjusting. Also maybe if you could try replacing the x and check with ionicons
|
…quirements met, and expand special character check
@kyle-ssg, made some changes including:
![]() |
Thanks so much, this looks great! |
@kyle-ssg, Awesome, Good to know |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Added a PasswordRequirements component to the signup form to provide real-time feedback on password requirements.
How did you test this code?
I tested this code by: