-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create change requests for segments #4265
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Uffizzi Ephemeral Environment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4265 +/- ##
==========================================
+ Coverage 97.20% 97.22% +0.01%
==========================================
Files 1171 1177 +6
Lines 40640 40803 +163
==========================================
+ Hits 39506 39671 +165
+ Misses 1134 1132 -2 ☔ View full report in Codecov by Sentry. |
Changes
This PR works in concert with this other PR on the workflows repo.
This PR introduces many changes to support the addition of segments in change requests. The primary logic around transferring change request segment data into the target segment data involves re-using logic that was originally written for the segment versioning.
Due to the primary manager (
.objects
) now including versioned or change requested segments copies, some amount of work was necessary to get all the aspects of the existing code to pass. The.live_objects
manager is used for segments that are not merely versions or change request segments but in some places manually filtering segments was the only solution.How did you test this code?
Added tests across the test suite, including new tests for duplicate segments to test filtering, as well as tests located in with the other workflows PR to get coverage of edge cases.