Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use environment feature state instead of fetching feature states #4188

Merged
merged 4 commits into from
Aug 12, 2024
Merged

feat: Use environment feature state instead of fetching feature states #4188

merged 4 commits into from
Aug 12, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jun 19, 2024 •
edited by matthewelwell
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

In order for the feature list page to function, it needs access to the features and feature states.

Prior to this the frontend got all feature states when fetching features and matched them up. Now that the backend returns the feature states in the features, this PR adjusts the Frontend to use that rather than fetching them.

Resolves #3301

How did you test this code?

  • Filtered , created and updated features
  • Created and updated versioned features
  • Created and updated MV features

@vercel Vercel
Copy link

vercel bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:59pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:59pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:59pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard chore labels Jun 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024 •
edited
Loading

Uffizzi Preview deployment-54841 was deleted.

matthewelwell
matthewelwell reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it looks good to me 👍 . Since it's quite a critical change, I'd love to get another pair of eyes on it as well, although I guess the E2E tests will cover this part of the app significantly.

@matthewelwell matthewelwell mentioned this pull request Jul 8, 2024
Open
4 tasks
@novakzaballa
Copy link
Contributor

@kyle-ssg why we don't use the RTK here?

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Jul 16, 2024 •
edited
Loading

It’ll be very difficult to migrate this given how integral and widely used it is. Though I did make versioning use it to make it easier when we do.

novakzaballa
novakzaballa approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, the functional tests are working.

@kyle-ssg
Merge branch 'refs/heads/main' into chore/use-combined-environment_fe…
038fea2 
…ature_state

# Conflicts:
#	frontend/common/stores/feature-list-store.ts
@kyle-ssg kyle-ssg requested a review from a team as a code owner July 31, 2024 10:36
@github-actions github-actions bot added chore and removed chore labels Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4188 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4188 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4188 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4188 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4188 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4188 Finished ✅ Results ✅

@github-actions github-actions bot added chore and removed chore labels Aug 7, 2024
@matthewelwell matthewelwell changed the title chore: Use environment feature state instead of fetching feature states feat: Use environment feature state instead of fetching feature states Aug 12, 2024
@kyle-ssg kyle-ssg added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit b1d49a6 Aug 12, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the chore/use-combined-environment_feature_state branch August 12, 2024 13:55
@flagsmithdev flagsmithdev mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees
No one assigned
Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browsing features too slow when there are lots of features
3 participants
@kyle-ssg @novakzaballa @matthewelwell