chore(saas/hubspot): create contacts with default domain #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
matthewelwell
commented
Apr 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3830 +/- ##
========================================
Coverage 95.93% 95.94%
========================================
Files 1103 1125 +22
Lines 34842 35613 +771
========================================
+ Hits 33427 34169 +742
- Misses 1415 1444 +29 ☔ View full report in Codecov by Sentry. |
matthewelwell
changed the title
zachaysan
approved these changes
Apr 24, 2024
api/tests/unit/integrations/lead_tracking/hubspot/_hubspot_responses.py
Outdated
Show resolved
Hide resolved
api/tests/unit/integrations/lead_tracking/hubspot/_hubspot_responses.py
Outdated
Show resolved
Hide resolved
matthewelwell
deleted the
chore(saas-hubspot)/create-contacts-with-default-domain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Add logic to create a lead in Hubspot when a user signs up but doesn't create or join an organisation.
How did you test this code?
Wrote some unit tests, as well as testing the hubspot API directly where needed.,