-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reading role permissions generates 500 errors #3009
fix: Reading role permissions generates 500 errors #3009
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Based on this Slack thread, I'm not sure this is the right solution. All roles should have an organisation attribute. I've marked this PR as draft until we have understood more about this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3009 +/- ##
=======================================
Coverage 95.99% 95.99%
=======================================
Files 1062 1062
Lines 32297 32297
=======================================
Hits 31005 31005
Misses 1292 1292 ☔ View full report in Codecov by Sentry. |
@novakzaballa I'm not sure if this code touches on it but if I go to https://app.flagsmith.com/organisation-settings -> member - groups - create a new group, the new group does not show up. I have to navigate to complete refresh the page for the group to show up. |
Other than the group thing I commented above, the approvers seems to be working just fine. I still think the user experience is confusing but I will take some time later this week and open a separate issue |
@gnumoreno That part of the code was not touched, this is a good catch, we would have to create an issue. |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
How did you test this code?