-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Audit Log records don't get created with threaded task processing #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrap threaded task runs in `transaction.on_commit` by default, make it configurable - Add docs, functioning typing
khvn26
requested review from
a team and
matthewelwell
and removed request for
a team
November 10, 2023 22:56
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2958 +/- ##
=======================================
Coverage 95.64% 95.65%
=======================================
Files 1012 1012
Lines 29181 29220 +39
=======================================
+ Hits 27911 27949 +38
- Misses 1270 1271 +1
☔ View full report in Codecov by Sentry. |
matthewelwell
requested changes
Nov 13, 2023
khvn26
force-pushed
the
fix/threaded-audit-log-fails-to-create
branch
from
November 13, 2023 10:50
9a1f826
to
a291cb4
Compare
matthewelwell
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2949
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
transaction.on_commit
by default, made it configurableHow did you test this code?
Unit tests cover the new code paths.
IDE (VSCode + pylance) highlights the task handler methods and attributes correctly.