Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Infinite loop 404 after leaving the organisation #2957

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix: Infinite loop 404 after leaving the organisation #2957

merged 2 commits into from
Nov 13, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Removed the item 'lastEnv' from AsyncStorage the user is no longer a member of the organization.

How did you test this code?

  1. At app.flagsmith.com log in as a user with access to organisations A & B and navigate to a project in Organisation B.
  2. In the Django admin, remove access for that user to organisation B.
  3. At app.flagsmith.com, refresh the page.
  4. The app no longer enters an infinite loop.

@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 10:44am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 10:44am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 10:44am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Nov 10, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023 •
edited
Loading

Uffizzi Preview deployment-40540 was deleted.

@novakzaballa novakzaballa linked an issue Nov 10, 2023 that may be closed by this pull request
App can get stuck in 404 loop after leaving an organisation #2955
Closed
matthewelwell
matthewelwell requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and confirmed this looks good. One minor comment related to the error message change.

frontend/web/components/pages/NotFoundErrorPage.js Outdated Show resolved Hide resolved
matthewelwell
matthewelwell approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the error message change.

@matthewelwell matthewelwell added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit 7b7f986 Nov 13, 2023
18 checks passed
@matthewelwell matthewelwell deleted the fix/infinite-loop-404-after-leaving-the-organisation branch November 13, 2023 10:47
@dabeeeenster dabeeeenster mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App can get stuck in 404 loop after leaving an organisation
2 participants
@novakzaballa @matthewelwell